Repository navigation
feat(review): stop on merged or closed PRs before reviewing and posting - #34
Merged
Merged
Conversation
## What/Why Check PR state before launching agents, have the orchestrator re-check before returning, and require a standalone state check right before posting. Three reviews in one session were wasted on PRs that merged mid-review, and one was posted after merge because the state check was chained into the post command. ## Proof it works pre-commit passes (markdownlint, check json). Docs-only change to SKILL.md; the bats suite covers reassess only and was not run (bats not installed locally). ## Risk Low. Adds checks to the review workflow; no scripts change. ## AI role Wording drafted by Claude Opus 5.5 from the session's failure analysis; human approved the three edit points before they were made. ## Review focus Whether "say so before launching" for approved or automerge PRs should instead stop and ask. Signed-off-by: jmeridth <jmeridth@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why
The review skill now checks PR state at three points: before launching agents, when the orchestrator returns, and right before posting. Reviews were running against PRs that merged mid-review, and one posted after merge because the state check was chained into the post command. The plugin is bumped to 0.1.22.
Proof it works
Docs-only change. pre-commit passes.
Risk
Low. It adds checks to the workflow text and changes no scripts.
AI role
Claude Opus 5.5 drafted the wording from a review of the failed runs. I approved the three edit points before they were made.
Review focus
Whether an already-approved or automerge PR should stop and ask, not just warn.